Use default namespace in RNAndroid / imagemanager / conversion #52751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
The only method use externally is
```
inline MapBuffer serializeImageRequest(
const ImageSource& imageSource,
const ImageRequestParams& imageRequestParams) {
```
all others can move to a private/anonymous namespace
Changelog: [Internal]
Differential Revision: D78709009
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78709009 |
|
This pull request was successfully merged by @christophpurrer in 52d8660 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 52d8660. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The only method use externally is
all others can move to a private/anonymous namespace
Changelog: [Internal]
Differential Revision: D78709009