Implement accessibilityOrder by building the accessibilityTree through addChildrenForAccessibility #52743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78669715 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Jul 21, 2025
…h addChildrenForAccessibility (facebook#52743) Summary: We can build an accessibility tree for Talkback by overriding addChildrenForAccessibility of ViewGroup. With this we just manually build a tree that contains the elements we care about in the order we want. We also try to keep most of the tree intact so that coopting works properly Changelog: [Internal] EDITS: After backout, fixed the issue where we were incorrectly setting the `accessibility_order_parent` tag the ReactAxOrderHelper class instead of the actual view. Also, made the cast safe to prevent any unexpected issues. Also refactored the ReactAxOrderHelper functions to not have the block scoped `traverse` functions in favor of just looping through the children of a view when calling them Differential Revision: D78669715
jorge-cab
force-pushed
the
export-D78669715
branch
from
7348e88 to
6cf5f5d
Compare
…h addChildrenForAccessibility (facebook#52743) Summary: Pull Request resolved: facebook#52743 We can build an accessibility tree for Talkback by overriding addChildrenForAccessibility of ViewGroup. With this we just manually build a tree that contains the elements we care about in the order we want. We also try to keep most of the tree intact so that coopting works properly Changelog: [Internal] EDITS: After backout, fixed the issue where we were incorrectly setting the `accessibility_order_parent` tag the ReactAxOrderHelper class instead of the actual view. Also, made the cast safe to prevent any unexpected issues. Also refactored the ReactAxOrderHelper functions to not have the block scoped `traverse` functions in favor of just looping through the children of a view when calling them Differential Revision: D78669715
|
This pull request was exported from Phabricator. Differential Revision: D78669715 |
jorge-cab
force-pushed
the
export-D78669715
branch
from
6cf5f5d to
55ce596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can build an accessibility tree for Talkback by overriding addChildrenForAccessibility of ViewGroup.
With this we just manually build a tree that contains the elements we care about in the order we want.
We also try to keep most of the tree intact so that coopting works properly
Changelog: [Internal]
After backout, fixed the issue where we were incorrectly setting the
accessibility_order_parenttag the ReactAxOrderHelper class instead of the actual view. Also, made the cast safe to prevent any unexpected issuesDifferential Revision: D78669715