Skip to content

Commit f0cbc93

Browse files
hoxyqmeta-codesync[bot]
authored andcommitted
Backout "[rn] Add CDP frame events" (#54676)
Summary: Pull Request resolved: #54676 # Changelog: [Internal] Reviewed By: sbuggay Differential Revision: D87549336 fbshipit-source-id: b94645ba0ed12979ed7129c767c38587420c6cc0
1 parent 97ad18a commit f0cbc93

File tree

2 files changed

+1
-91
lines changed

2 files changed

+1
-91
lines changed

packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.cpp

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -750,63 +750,6 @@ void PerformanceTracer::enqueueTraceEventsFromPerformanceTracerEvent(
750750
.args = folly::dynamic::object("data", std::move(data)),
751751
});
752752
},
753-
[&](PerformanceTracerSetLayerTreeIdEvent&& event) {
754-
events.emplace_back(
755-
TraceEventGenerator::createSetLayerTreeIdEvent(
756-
std::move(event.frame),
757-
event.layerTreeId,
758-
processId_,
759-
event.threadId,
760-
event.start));
761-
},
762-
[&](PerformanceTracerFrameBeginDrawEvent&& event) {
763-
folly::dynamic data = folly::dynamic::object(
764-
"frameSeqId", event.frameSeqId)("layerTreeId", 1);
765-
766-
events.emplace_back(
767-
TraceEvent{
768-
.name = "BeginFrame",
769-
.cat = {Category::Timeline},
770-
.ph = 'I',
771-
.ts = event.start,
772-
.pid = processId_,
773-
.s = 't',
774-
.tid = event.threadId,
775-
.args = std::move(data),
776-
});
777-
},
778-
[&](PerformanceTracerFrameCommitEvent&& event) {
779-
folly::dynamic data = folly::dynamic::object(
780-
"frameSeqId", event.frameSeqId)("layerTreeId", 1);
781-
782-
events.emplace_back(
783-
TraceEvent{
784-
.name = "Commit",
785-
.cat = {Category::Timeline},
786-
.ph = 'I',
787-
.ts = event.start,
788-
.pid = processId_,
789-
.s = 't',
790-
.tid = event.threadId,
791-
.args = std::move(data),
792-
});
793-
},
794-
[&](PerformanceTracerFrameDrawEvent&& event) {
795-
folly::dynamic data = folly::dynamic::object(
796-
"frameSeqId", event.frameSeqId)("layerTreeId", 1);
797-
798-
events.emplace_back(
799-
TraceEvent{
800-
.name = "DrawFrame",
801-
.cat = {Category::Timeline},
802-
.ph = 'I',
803-
.ts = event.start,
804-
.pid = processId_,
805-
.s = 't',
806-
.tid = event.threadId,
807-
.args = std::move(data),
808-
});
809-
},
810753
},
811754
std::move(event));
812755
}

packages/react-native/ReactCommon/jsinspector-modern/tracing/PerformanceTracer.h

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -294,35 +294,6 @@ class PerformanceTracer {
294294
HighResTimeStamp createdAt = HighResTimeStamp::now();
295295
};
296296

297-
struct PerformanceTracerSetLayerTreeIdEvent {
298-
std::string frame;
299-
int layerTreeId;
300-
HighResTimeStamp start;
301-
ThreadId threadId;
302-
HighResTimeStamp createdAt = HighResTimeStamp::now();
303-
};
304-
305-
struct PerformanceTracerFrameBeginDrawEvent {
306-
int frameSeqId;
307-
HighResTimeStamp start;
308-
ThreadId threadId;
309-
HighResTimeStamp createdAt = HighResTimeStamp::now();
310-
};
311-
312-
struct PerformanceTracerFrameCommitEvent {
313-
int frameSeqId;
314-
HighResTimeStamp start;
315-
ThreadId threadId;
316-
HighResTimeStamp createdAt = HighResTimeStamp::now();
317-
};
318-
319-
struct PerformanceTracerFrameDrawEvent {
320-
int frameSeqId;
321-
HighResTimeStamp start;
322-
ThreadId threadId;
323-
HighResTimeStamp createdAt = HighResTimeStamp::now();
324-
};
325-
326297
using PerformanceTracerEvent = std::variant<
327298
PerformanceTracerEventTimeStamp,
328299
PerformanceTracerEventEventLoopTask,
@@ -331,11 +302,7 @@ class PerformanceTracer {
331302
PerformanceTracerEventMeasure,
332303
PerformanceTracerResourceSendRequest,
333304
PerformanceTracerResourceReceiveResponse,
334-
PerformanceTracerResourceFinish,
335-
PerformanceTracerSetLayerTreeIdEvent,
336-
PerformanceTracerFrameBeginDrawEvent,
337-
PerformanceTracerFrameCommitEvent,
338-
PerformanceTracerFrameDrawEvent>;
305+
PerformanceTracerResourceFinish>;
339306

340307
#pragma mark - Private fields and methods
341308

0 commit comments

Comments
 (0)