Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subtle color variables for improved contrast #4544

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Mar 20, 2025

Enhance the contrast of subtle color variables in the custom theme to improve visibility and accessibility.

continues #4541

before
image

after
image

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 1ab17c7
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/67dc181b6b767d00089b196d
😎 Deploy Preview https://deploy-preview-4544--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hichemfantar hichemfantar marked this pull request as ready for review March 20, 2025 10:35
@Simek
Copy link
Collaborator

Simek commented Mar 20, 2025

As suggested in previous PR we should aim at complying with WCAG AA (WCAG AAA is too strict, and restrains the design options a lot). Also the color difference between regular font color, and subtle variant seems to be too low after the updates in this changeset:

PROD

Screenshot 2025-03-20 at 12 25 53

Preview

Screenshot 2025-03-20 at 12 25 30

@hichemfantar
Copy link
Contributor Author

alright i dropped the colors to AA

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes on the preview, thanks for the follow up! 🚀

@Simek Simek merged commit 71b23ed into facebook:main Mar 20, 2025
3 checks passed
@hichemfantar hichemfantar deleted the accessible-table-headers branch March 20, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants