Inconsistent inheritance check follow ups #1298
Open
+57
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any errors would be reported again by bad-override checks. Removing redundant error reporting (which is also what Pyright is doing).
Factor out code for determining whether an override is correct, so that we can use it to skip fields when checking multiple inheritance consistency.
We're skipping them for the override checks already. Re-using the refactored function to also skip them during multiple inheritance checks. Newly added test is passing because we don't check methods in multiple inheritance checks yet. Adding the test there to prevent regressions.
Patch accepted upstream in python/typeshed#14809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a series of minor diffs building up to the correct handling of multiple inheritance checks for methods, following up from #1196.
Main changes:
Next steps:
We're close to handle multiple inheritance checks for methods. We still have some errors on stdlib due to handling of type variables (#1196 (comment) item 2), which I consider as a blocker.