rank re-exports beneath other exports in module completions #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndmitchell
approved these changes
Oct 15, 2025
…#1297) Summary: facebook#1149 reports type stubs appearing in the completions of a stdlib module. it turns out these are legitimate completions for os.pyi, but not os.py. the real fix is in facebook#1090. but in the meantime, i'll derank re-exports beneath items defined in the module. Reviewed By: ndmitchell Differential Revision: D84645691
kinto0
force-pushed
the
export-D84645691
branch
from
58987ff to
f8b733d
Compare
|
This pull request has been merged in 294a2a5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#1149 reports type stubs appearing in the completions of a stdlib module.
it turns out these are legitimate completions for os.pyi, but not os.py. the real fix is in #1090.
but in the meantime, i'll derank re-exports beneath items defined in the module.
Differential Revision: D84645691