Hovering over type ignore shows error message

[Adist319]

Addresses #890. Implements hover functionality that shows suppressed errors when hovering over # pyrefly: ignore or # type: ignore comments.

[meta-codesync]

@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D84829334.

[kinto0]

looks great! thank you for the contribution. and sorry it took us a while to get to this.

just a minor suggestion to keep the APIs more clear: we should add the comment range to the Suppression struct so we parse once instead of parsing on the fly.

[Adist319]

@kinto0 Thanks for the feedback! Refactored to use the comment range suppression API

• Moved comment parsing logic into parse_ignores() so ranges are computed once during initialization
• Added TextRange field to Suppression struct to store pre-computed comment positions
• Simplified hover.rs by using the new get_comment_range() API
• Fixed pending suppression handling to properly clear on empty lines
• I added a unit/smoke test for above-line ignores in ignore.rs. I was having issues adding integration tests
  for above-line ignores in the hover test file due to the cursor marker (#^) interfering with the suppression
  logic. The marker line sits between the comment and code, breaking the above-line detection. Let me know if this is fine.

[kinto0]

thanks for making the changes so quickly! looks like you improved string parsing a lot, too

[yangdanny97]

Review automatically exported from Phabricator review in Meta.

[meta-codesync]

@kinto0 merged this pull request in 3e8787b.