Ninja update to avoid build fail on python3.13 #2392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @novitae! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
CC @Orvid—the old bundled ninja version appears to have become a source of confusion (facebook/watchman#1284, facebook/mvfst#398). While |
|
@Orvid has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Jun 25, 2025
Summary: When building from scratch folly on python 3.13, here is the issue you will encounter: ``` Extract /private/tmp/follyt/downloads/ninja-v1.10.2.tar.gz -> /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz Building ninja... --- + cd /private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2 && \ + /opt/homebrew/opt/[email protected]/bin/python3.13 \ + configure.py \ + --bootstrap Traceback (most recent call last): File "/private/tmp/follyt/extracted/ninja-v1.10.2.tar.gz/ninja-1.10.2/configure.py", line 26, in <module> import pipes ModuleNotFoundError: No module named 'pipes' Command '['/opt/homebrew/opt/[email protected]/bin/python3.13', 'configure.py', '--bootstrap']' returned non-zero exit status 1. !! Failed ``` (`python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt`) This is because the version `1.10.2` of ninja uses `pipes`, which has been deprecated since python 3.11 and removed in python 3.13. [^1] This PR changes the ninja dependency from 1.10.2 to 1.12.1. [^1]: https://docs.python.org/3/library/pipes.html X-link: facebook/folly#2392 Reviewed By: yfeldblum Differential Revision: D76523565 Pulled By: Orvid fbshipit-source-id: 8ba5b96b3a01334ab9b04e62c80588868273bb25
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from scratch folly on python 3.13, here is the issue you will encounter:
(
python3.13 ./build/fbcode_builder/getdeps.py build --scratch-path /tmp/follyt)This is because the version
1.10.2of ninja usespipes, which has been deprecated since python 3.11 and removed in python 3.13. 1This PR changes the ninja dependency from 1.10.2 to 1.12.1.
Footnotes
https://docs.python.org/3/library/pipes.html ↩