Fodboldbane #2530
Draft
Fodboldbane #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Also updated the changelog Reviewed By: samodom Differential Revision: D32785335 fbshipit-source-id: 0868e96d66e9da67fc7969500a7da1a1378050c2
Summary: We need to fix: 1. AEM Conversion Filetring endpoint/request names 2. Add special processing for content id 3. Combine catalog networker and AEM networker Reviewed By: wx0165927473, samodom Differential Revision: D32782549 fbshipit-source-id: c02e20d9ff7e116ecdba2c784a164a1831acb553
Summary: See updated changelog. Reviewed By: NSProgrammer Differential Revision: D32809771 fbshipit-source-id: cefc568518155628503d0a3f13994c978c688825
Summary: This diff cleans up the payload parsing logic. It makes it easy to add new keys we need to listen for when parsing a gaming entry url into a native game. To add a new listener: Add it to the keys list. Create a new delegate Method Check for the key in the GameEntryInfo and The third party app implemented the delegate method for said key If so call the delegate method. Reviewed By: jawwad Differential Revision: D32808171 fbshipit-source-id: 799cd3bb2b1214ec3821e2bd37d59a2a55d9cc93
Summary: In this diff we add a listener to look for a tournament ID and payload when a third party game is started from a FB entry point. Reviewed By: jawwad Differential Revision: D32808372 fbshipit-source-id: fa552730519e354b43eef601c65eaa92a06caf41
Summary: This adds two new API's to tournaments share update and post score. We need these APIs to allow from developers to trigger updating a tournament using an ID giving when the user enters a native game by clicking a tournament on FB. Reviewed By: jawwad Differential Revision: D32808504 fbshipit-source-id: b59b01411c66685a1927b9d5835f24cd7511a8e0
Reviewed By: wx0165927473 Differential Revision: D32846912 fbshipit-source-id: f9f2998e3cfe49369e003a0e33ddb865dbb0901c
…2.2.0 Reviewed By: joesus Differential Revision: D32874575 fbshipit-source-id: 9b7dbc9c50fdb0133180488c63a94998a255e59e
Summary: Relevant information in the changelog. Reviewed By: samodom Differential Revision: D32954165 fbshipit-source-id: 9cc512b8ec6c79be557fa54440fdb2528f830b34
Reviewed By: jamestouri Differential Revision: D32955602 fbshipit-source-id: 7327ea429a3bb4f8f46d6d3ea43342232d275539
Summary: $title Reviewed By: jawwad Differential Revision: D32960999 fbshipit-source-id: 566899e8fd81f57197dcc80d5c77e81908391fb5
Summary: This will make it easier to use SPM with tvOS. Additionally gates some code that should not be available on tvOS. Reviewed By: samodom Differential Revision: D32958438 fbshipit-source-id: c38e07159ee1aaa6f2c3935c5d5f404fc7851238
Summary: Adding these targets will allow us to add tvOS slices to the AEMKit XCFrameworks which will simplify using SPM. Reviewed By: samodom Differential Revision: D32933339 fbshipit-source-id: 6fe0f402e8f77b2b45f00aa926a1e2345a251951
Summary: Addresses facebook#1961 Reviewed By: jawwad, dreamolight Differential Revision: D32900654 fbshipit-source-id: 18634b6ec9f78942639493bae607ab8861f54eb1
Reviewed By: joesus Differential Revision: D32990143 fbshipit-source-id: 7c028c927fd7600a1d3103343da1a2bdc1d473ff
…2.2.1 Summary: I ran this on the release branch: remote/fbobjc/releases/release-ios-sdk-v12.2.1 ``` time swift run --build-path=`mkscratch path` runner prepare-release | xcpretty ``` I created this diff on the release branch but I'm rebasing this onto master first. It needs to be in master in case someone points their SPM to master, that way they still get the latest release. Once it's in master it will be picked into the release branch. Reviewed By: samodom Differential Revision: D32988695 fbshipit-source-id: 12fa9804177e9ab391b97f69b5460ae1805d6689
… v12.2.1 Reviewed By: samodom Differential Revision: D33000400 fbshipit-source-id: c6f547d68c48ee827255b98d980f224cf3e5529d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for proposing a pull request!
To help us review the request, please complete the following:
Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)
Test Plan
Test Plan: Add your test plan here