Release/3.4.11 #3260
Open
Release/3.4.11 #3260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vahidkay-meta
commented
May 28, 2025
vahidkay-meta
commented
- Tweak - Removing Variant Level Sync by @SayanPandey in Removing Variant Level Sync #2931
- Tweak - Removed concept of Product Group Deletion from the plugin by @vinkmeta in Removed concept of Product Group Deletion from the plugin #3062
- Tweak - Tagging woo all products using a flag by @SayanPandey in Tagging woo all products #3165
- Add - A simple column for Woo All Products sync in feed file by @SayanPandey in Adding a simple column for Woo All Products sync in feed file #3197
- Tweak - Preparation for migrating Batch API to Graph API by @vinkmeta in Preparation for migrating Batch API to Graph API #3203
- Tweak Block Product Group Creation for Simple Products by @vinkmeta in Block Product Group Creation for Simple Products #3204
- Fix - Removed html tags from product set description by @mshymon in Fix - Removed html tags from product set description. #3230
- Fix - Fix for the rollout Switches by @vinkmeta in Hotfix for Rollout Switches #3236
- Add - Opt out sync experience. by @SayanPandey in Opt out sync experience #3220
- Fix - Added a transient flag to avoid flooding of product set api requests by @vinkmeta in Added a transient flag to avoid flooding of api requests #3245
- Fix - Additional check for the opt-out banner by @SayanPandey in Additional check for opt out banner #3259
- Fix - Bump up GraphAPI version to 21 by @vahidkay-meta in Updated the GraphAPI version to 21 #3219
Summary: 1. The Variant level sync is removed in this PR for Variable products. 2. The Sync option now exist in Facebook tab. 3. Selecting your choice of sync will be effective on the product and all its variants. _In general we are moving forward with Syncing at Product level than Variant level._ | Before | After| |----------|----------| | 1. At Variant level sync controls | 1. At variant level sync controls removed | |  |  | | 2. At facebook tab sync controls missing | 2. At facebook tab Sync controls added | |  |  | 1. Make a variant product 2. Add some variant attributes 3. Now make variants 4. Try to use the sync - do not sync options in facebook tabs 5. Observe the changes in Catalog in commerce manager Pull Request resolved: #2931 Reviewed By: devbodaghe Differential Revision: D70891355 Pulled By: SayanPandey fbshipit-source-id: c7ff23076ccce86efc5a02c7ff0ab7250b52a1e7
Summary: Removed concept of Product Group Deletion from the plugin Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). Removed concept of Product Group Deletion from the plugin Pull Request resolved: #3062 Test Plan: ./vendor/bin/phpunit Reviewed By: devbodaghe Differential Revision: D73082810 Pulled By: vinkmeta fbshipit-source-id: 9eab588b0d417a9b9ac72e9d4010daa08ef56f64
Summary: ## Tagging woo all products and background validation improvement The flag introduced in this PR would help us tag the products (especially variations) coming to us as part of Woo All Products. ### Type of change The change is simple. Just adding an attribute. And a simple background validation improvement. Here if we have already parent value setup for sync we don't check for its children. ## Checklist - [] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). Pull Request resolved: #3165 Test Plan: In order to test this please follow the following steps: 1. Make a variable product in an earlier version 2. Upgrade the version. 3. Not update the products again 4. You should see the flag in API call params from the browser. Reviewed By: vinkmeta Differential Revision: D74466000 Pulled By: SayanPandey fbshipit-source-id: 65ba2252c12c491d9036abcbcaa8a09791df25b0
Summary: Adding a simple column for Woo All Products sync in feed file Please delete options that are not relevant. Simple change to add a column in feed file. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). Pull Request resolved: #3197 Reviewed By: gurtejrehal Differential Revision: D74814707 Pulled By: SayanPandey fbshipit-source-id: 94c9971fb434f7b3cceec1e54324598a6218cd90
Summary: ## Description Migrating Batch API to Graph API for individual product items ### Type of change Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Preparation for migrating Batch API to Graph API Pull Request resolved: #3203 Reviewed By: crisojog Differential Revision: D74951899 Pulled By: vinkmeta fbshipit-source-id: e4be128e7a5acd377c87c2c7ee9231b17455ae9b
Summary: Blocked Product Group Creation for Simple Products as it is handled by ingestion automatically. - Bug fix (non-breaking change which fixes an issue) - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). Block Product Group Creation for Simple Products Pull Request resolved: #3204 Reviewed By: crisojog Differential Revision: D74957834 Pulled By: vinkmeta fbshipit-source-id: 349e08b62f04ce119415c65e3baaebc33385d0c2
Summary: Problem. The raw WC category description contains html tag (e.g. <p>). This gest synced to Meta and the string is not expected to contain the tags. Fix. Remove the tags from the raw description before it is synchronised to Meta. - Bug fix (non-breaking change which fixes an issue) - Fix - Removed html tags from product set description. Pull Request resolved: #3230 Test Plan: `./vendor/bin/phpunit --filter ProductSetSyncTest` Reviewed By: nrostrow-meta, carterbuce Differential Revision: D75236740 Pulled By: mshymon fbshipit-source-id: 73a06bf35414d2a872b6d88ce6429bc0cc31b1bc
Summary: Hotfix for Rollout Switches - Bug fix (non-breaking change which fixes an issue) - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). Hotfix for Rollout Switches Pull Request resolved: #3236 Reviewed By: francorisso, carterbuce Differential Revision: D75309500 Pulled By: vinkmeta fbshipit-source-id: 419faab6759281c23d2f11922632328b70498ecd
Summary: Al part of Woo All products project we are aiming at bring in product data for helping advertisers in ease of syncing and overall experience of facebook for woocommerce. This change will notify advertisers with banners on facebook for woocommerce admin page, notifying that new version upgrade will help them sync all products. The will have an option to opt out as well, provided in the banner. Please inspect the screenshots. Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). - Pull Request resolved: #3220 Test Plan: 1. Go to Marketing tab in WooCommerce 2. Click on facebook 3. You should see the banner  <img width="1545" alt="Screenshot 2025-05-20 at 7 05 22 pm" src="https://github.com/user-attachments/assets/45836eb4-d106-483a-a028-37d60fe7f1df" /> Reviewed By: vinkmeta Differential Revision: D75095017 Pulled By: SayanPandey fbshipit-source-id: f1dd1754f6cb7432e962886360c45b8d05ef0972
Summary: ## Description Added a transient flag to avoid flooding of Product Sets api requests since the daily heartbeat hook being set by every user visit. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Added a transient flag to avoid flooding of product set api requests Pull Request resolved: #3245 Reviewed By: SayanPandey Differential Revision: D75419700 Pulled By: vinkmeta fbshipit-source-id: 1b1f8ea43b5a19e5a82f49c7fb4874ebf5862a4b
Summary: ## Description Bug fix This code should show new banner ### Type of change Bug fix ## Checklist - [] I have commented my code, particularly in hard-to-understand areas. - [] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). Pull Request resolved: #3259 Reviewed By: renjith7189, crisojog Differential Revision: D75521057 Pulled By: SayanPandey fbshipit-source-id: 857fa2bf605f1314fa07879be4463b7b6db7f478
Summary: ## Description This PR bumps up the GraphAPI version to 21. There's no breaking change on v21 that affects the current plugin features, at least according to the upgrade notice. ### Type of change - Tweak ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Fix - bump up GraphAPI version to 21. Pull Request resolved: #3219 Test Plan: The plugin needs to be e2e tested to ensure the functionality is intact. Reviewed By: maxkozin Differential Revision: D75523124 Pulled By: vahidkay-meta fbshipit-source-id: abb40ad1d91974e356b3c351f9c64258857bacf2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.