feat: support React 19 #10745
Closed
feat: support React 19 #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: new feature
⚡️ Lighthouse report for the deploy preview of this PR
|
This was referenced Dec 6, 2024
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +73.7 kB (+0.65%) Total Size: 11.3 MB
ℹ️ View Unchanged
|
|
Size Change: +76.7 kB (+0.65%) Total Size: 11.8 MB
ℹ️ View Unchanged
|
slorber
added
the
Argos
2 tasks
1 task
|
This might be a stupid question, but how do I manage to use react 19 in my repo when all docusaurus packages define this: https://github.com/facebook/docusaurus/blob/main/package.json#L116C16-L116C22 We have a monorepo with docusaurus in there, and I am getting peer dependency issues |
|
@CumpsD the link you provided is not a "Docusaurus package", it's the root of our monorepo that still uses React 18 in some parts (notably unit tests) The v3.7 packages published on npm have "peerDependencies": {
"react": "^18.0.0 || ^19.0.0",
"react-dom": "^18.0.0 || ^19.0.0"
},https://github.com/facebook/docusaurus/blob/main/packages/docusaurus/package.json#L95
If you don't share your Docusaurus version, and what those issues are, I can't help much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed, replaced by retro-compatible PR that allows using React 19 in Docusaurus v3.x (#10763)
Motivation
Draft PR to see what it takes to upgrade to Docusaurus v19
We'll merge it only for Docusaurus v4, alongside other breaking changes
Test Plan
CI
Test links
https://deploy-preview-10745--docusaurus-2.netlify.app/