Skip to content

Conversation

@slorber
Copy link

@slorber slorber commented Apr 23, 2021

Use an unreleased version of Docusaurus to test the webpack5 support works for this site, detect potential problems, and perf improvements.

See also facebook/docusaurus#4089

Perf improvements

  • First build (local): 30s
  • Second build (local): 20s

Note: is CRA still using Netlify?
It seems disabled since a few weeks: https://app.netlify.com/sites/create-react-app/deploys
Should the Netlify config file be deleted?
Wouldn't it be better to have docs deploy previews?

@slorber slorber marked this pull request as ready for review April 30, 2021 17:45
@slorber
Copy link
Author

slorber commented May 1, 2021

ready for review, let me know if anything does not work

not sure why the CI is failing 😅

Copy link
Contributor

@iansu iansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, as long as the docs site still works. Is your intention that we merge and deploy this or were you just testing if it worked?

@slorber
Copy link
Author

slorber commented May 13, 2021

My intention was to test Webpack 5 on a lot of open-source sites before we release the Docusaurus 2 beta :)

https://docusaurus.io/blog/2021/05/12/announcing-docusaurus-two-beta

As it is now released, it's up to you if you want to upgrade now or not

@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jun 26, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants