Js #11
Open
Js #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go |
ghost
approved these changes
Jan 5, 2023
Speedytats
approved these changes
Mar 8, 2023
Speedytats
approved these changes
Mar 8, 2023
harshsingh32
approved these changes
Apr 18, 2023
cesarapascual
approved these changes
Apr 19, 2023
* Consistently wrap (::) The (::) was handled differently in several places: pattern/expressions, with/without argument. Take care of parenthesis in the `fmt_longident` function instead.
* Fix formatting of cinaps comments with strings Strings containing breaks must carefully avoid changing the content of strings while indenting the whole code.
* Protect match after `fun _ : _ ->` Add a missing check for exposed matches.
* test_branch: Show diff summary * test_branch: Allow running ocp-indent only once Allow to test the difference in indentation between ocp-indent and ocamlformat by passing the same executable to both `-a` and `-b`. * test_branch: Inverse the meaning of `-s` The summary is always useful and doesn't need to be removed when diffs are shown. * GA: Don't show diffs when comparing with ocp-indent It's too big to be rendered properly. The numstat is the interesting data.
* ocp-indent-compat: Don't parse cinaps as doc * Strip indentation out of cinaps comments Parse cinaps comments the same way as code blocks are parsed in doc-comments. The baseline indentation is detected and stripped out of the code before it's parsed. This avoids changing string literals spanning several lines. The baseline indentation is the same as for unwrapped comments: It's the largest indentation common to every lines of the comment.
* Align pattern alias The rhs of a `as` in a pattern should be aligned to the lhs when parenthesis are added. Increases readability, especially when there are nested parenthesis.
* ocp-indent-compat: Docked fun on same line A fun/function after an apply must be docked only if it starts on the first line of the apply.
* ocp-indent-compat: Align module arguments
The ocp-indent rule works on the output of the corresponding test rule instead of the reference file in the source tree. This remove the need to call `runtest` a second time.
* Fix crash with exp-grouping and if-then-else The formatting for if-then-else did not account for the begin-end in some cases and generated invalid syntax.
The crash was caused by an Ast rule that is outdated since #2191.
* Make Cmt.t abstract Preliminary to changing its representation. * Don't mix comments and docstrings Comments and docstrings no longer have to be differentiated before formatting. Concatenating "*" to docstrings is no longer necessary. Some comments starting with `(**` were in fact not docstrings. What is a docstring is now dictated by the lexer, which removes this kind of bug.
Code block containing non-ascii characters, even if not encoded using latin1, raise this alert:
Alert deprecated: ISO-Latin1 characters in identifiers
Similarly to the warning 50 and because formatting of code block is on a
best-effort basis, this alert is disabled.
* Simplify escaping of '+' and '-' * Don't escape `@` in the middle of a word The `@` char must be escaped at the beginning of a word to not be confused with tags. This escaping is not necessary in the middle of a word and is removed.
* Don't escape balanced brackets in code spans
Odoc accepts nested balanced angle brackets in code spans:
[ [] \] \[ ]
This removes the unecessary escaping.
* Add a test for re-escaping changing the comment
This representation is made abstract in cmdliner 2.0.0.
Co-authored-by: Copilot <[email protected]>
Cmdliner 2.0.0 compat
Label arg begin
…nstraint bugfix : Double parens functor constraint
…nstraint-fix promote test from #2678 and update changelog
* showcase issue * fix issue * add test and changelog
* fix floating doc comments interaction with `;;` expressions * changelog
* `last_arg` and `has_label` is computed from context, `label` is given in `pro`.
* fix doc comment interaction with ;; * changelog * clearer changelog * fmt
* encode the information of attribute and extension position in the AST * remove using of source to check extension syntax * format * fix bug * add test * fix comment in between % and ext * changes * fix beginend - add Space like before - format postfix atributes in postfix position. * add attribute test * consistent infix attributes spacing * add test from issue #2652 * remove extra parens * format * fmt
* apply begin fun on one line * fmt * changelog * showcase infix apply begin function issue * fix infix apply begin function issue
This introduces a workflow for dune package management. It would help us ensure the package builds with dune developer preview
* showcase issue * fix issue * changelog
While we want to keep an eye on this, we don't want to make it a hard requirement
* promote ocp docking ofr infix apply. * fmt * changelog
* fix crash with inline record type variable * update changelog * promote tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me gustaría probar