Add queriesRunner #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function that let's you run an array of queries synchronously with optional parameters
crianonim
requested review from
jackbridger,
rooberrydev,
tonylomax and
victormasson21
Contributor
|
love the way you wrapped the variables and the query in an array Will try and spend some more time looking at this to make sure I properly understand everything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function that let's you run an array of queries synchronously with optional parameters
Dear DFIO,
I am suggesting a solution to one of your problems. I know you already solved it differently, but maybe just have a look. This way you still can execute your queries in order and have them all used parametrized queries. I read that Postgres executes one at the time anyway.
This is your project so I would expect you to instead just merging this PR, just check out my branch and play with it copy,paste etc. without my commit. That is if you like my solution and more importantly if you want to continue this project.
This problem would be solved even easier (and be more readable) if you didn't mind playing with Promises... (I can elaborate if you care)