fix(js/ts): date arithmetic: PM parsing, AddMonths day clamp, AddYears offset#4744
Open
Thorium wants to merge 1 commit into
Open
fix(js/ts): date arithmetic: PM parsing, AddMonths day clamp, AddYears offset#4744Thorium wants to merge 1 commit into
Thorium wants to merge 1 commit into
Conversation
- The fallback parser added the PM designator as 720 seconds
(12 minutes instead of 12 hours), so Parse("3:30 PM") gave 3:42;
also added the missing 12 AM -> 00 handling
- AddMonths landed one day early whenever month+delta was a positive
multiple of 12 (newMonth % 12 = 0 made daysInMonth clamp day 31
to 30); normalization rewritten in canonical modular form in both
Date and DateOffset
- DateTimeOffset.AddYears read raw UTC fields instead of
offset-adjusted ones, shifting the wall clock by the offset
Thorium
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(split from #4738)