Merge pull request #116 from yellowierd0/update-rule-extra-ecs-params

allow extra EcsParameters to not be lost when updating rule
fabfuel · Sep 29, 2019 · 15d2a78 · 15d2a78
2 parents 7eb692e + b763bfc
commit 15d2a78
Showing 1 changed file with 3 additions and 12 deletions.
diff --git a/ecs_deploy/ecs.py b/ecs_deploy/ecs.py
@@ -125,18 +125,9 @@ def run_task(self, cluster, task_definition, count, started_by, overrides,
 
     def update_rule(self, cluster, rule, task_definition):
         target = self.events.list_targets_by_rule(Rule=rule)['Targets'][0]
-        self.events.put_targets(
-            Rule=rule,
-            Targets=[{
-                'Arn': task_definition.arn.partition('task-definition')[0] + 'cluster/' + cluster,
-                'Id': target['Id'],
-                'RoleArn': target['RoleArn'],
-                'EcsParameters': {
-                    'TaskDefinitionArn': task_definition.arn,
-                    'TaskCount': 1
-                }
-            }]
-        )
+        target['Arn'] = task_definition.arn.partition('task-definition')[0] + 'cluster/' + cluster
+        target['EcsParameters']['TaskDefinitionArn'] = task_definition.arn
+        self.events.put_targets(Rule=rule, Targets=[target])
         return target['Id']