Required Level added to Runewizard #1
Conversation
|
Just note that I haven't tested any of theses changes when hosting on Github.io |
|
Hello there! This doesn't work as is. For testing ; assuming you want to keep poking it ; you need to install Jekyll. Then you can do That said, when I tried even my When that is done the table doesn't display properly. You have to also edit Anyways, I fixed main.js, is this what you are looking for?
I guess it can be useful to sort by required level though back when I played I found there's only a handful you can make at low level easily, and by the time you get runes to make the really good ones, you're already in Hell difficulty :) So at first I thought maybe I'd prefer to add "Required Level" as part of the runewords popups, but I guess adding one small column to the table is also fine, this lets you sort the Runewords by level. If I have time I'd like to rewrite this with VueJS, would make a lot more sense and simpler to edit. We'll see. I guess I may as well push the changes I made locally, including your commits, since you spent some time adding the levels in there. Let me know if the picture above is what you wanted. I'll see if I can push the changes this afternoon. |
|
Hello there,
Great to see you going back to this after 7 years haha.
Yes the picture you've shared is exactly what I was looking for Diablo 2
If you need anything else from me please let me know. I would love to see
that happening.
|
|
@migouelBL It looks like you tried adding level into the Runes.txt file. I will have to ignore those changes. Those are the spreadsheet style datafiles straight out of the game's data files, used by the scripts. You can't change the meaning of a column in there, and even assuming you wanted to update the Perl scritps that parse this data, then you'd want to make a new data file otherwise when a new patch comes that did some gameplay updates, we'd extract the new datafiles and overwrite whatever was changed locally. Runewizard doesn't use these files in any case. I guess I could have but there aren't so much data for the runewords alone, so I entered the Runewords data manually, and Runwewizard is more stand alone (could realistically made into its own little webpage or even a little ios app). The |
|
I mostly just need the level data you inputted in main.js. No need to update the commits, I should be able to merge the relevant ones into the master branch. |
|
Aw good to know. Ok. I thought someone had made this text file.
…On Thu., Feb. 25, 2021, 11:11 a.m. Fabrice D. ***@***.***> wrote:
@migouelBL <https://github.com/migouelBL> It looks like you tried adding
level into the Runes.txt file. I will have to ignore those changes. Those
are the spreadsheet style datafiles straight out of the game's data files,
used by the scripts. You can't change the meaning of a column in there, and
even assuming you wanted to update the Perl scritps that parse this data,
then you'd want to make a new data file otherwise when a new patch comes
that did some gameplay updates, we'd extract the new datafiles and
overwrite whatever was changed locally.
Runewizard doesn't use these files in any case. I guess I could have but
there aren't so much data for the runewords alone, so runwewizard is more
stand alone as a page. The Item Bonuses page does parse those files, but
it doesn't need the level information.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHB27XSVUNSTX34KYSTXSP3TAZZERANCNFSM4YFVSXIQ>
.
|
|
I'm sorry I'm not proficient with git enough to handle merging the pull request as is, I don't have a easy way of canceling the Runes.txt commit. I did some cherry-picks from your PR branch, and merged into master maintaining the auhor information. Looking into having the Github pages update. |
|
PS: the online version is updated. I changed the URLs to remove the |
|
Hi @migouelBL Happy to let you know Runewizard has a new repo, completey rewritten in modern Javascript. As it is a new repo I haven't been able to maintain your PR. Thanks again for providing the required levels data! Should you find any incorrect data or maybe a typo in the new live version of Runewizard, please let me know. The new version data files are in /src/data/ folder. |
Added Required Level to Runewizard