Ignore 404 error when resetting storage. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When browser restarts and session cookie is deleted, deleteSession sends session id from localStorage and gets a 404 in response. Login then does not send POST to user/sessions for a new session. I'm not sure about this solution, but works for me for now. Still leaves issue with 401 response, when logged in from another client (like Platform UI). But in that case deleting cookie/restarting browser will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browser restarts and session cookie is deleted, deleteSession sends session id from localStorage and gets a 404 in response. Login then does not send POST to user/sessions for a new session. I'm not sure about this solution, but works for me for now. Still leaves issue with 401 response, when logged in from another client (like Platform UI). But in that case deleting cookie/restarting browser will work.