-
Notifications
You must be signed in to change notification settings - Fork 47
[Behat] Add Textline fieldtype BDD tests #552
base: master
Are you sure you want to change the base?
Conversation
@@ -2,4 +2,4 @@ | |||
|
|||
cd $HOME/build/ezplatform | |||
|
|||
php bin/behat -vv --profile=platformui --tags='~@edge' | |||
php bin/behat -vv --profile=platformui --tags='~@edge && ~@notWorking' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already have a tag called @\broken, should use the same
+1 (however dependency in behat bundle needs to pass, and merge, and this then needs to pass, before merge here) |
## | ||
@javascript @common | ||
Scenario: A Content of an Content Type that has a text line fieldtype must have a text field | ||
Given a Content Type with an "text line" Field exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given a Content Type with a "Text Line" Field Definition exists
?
I would write our domain names with the first letter uppercased. Also, a Content Type is made of Field Definitions, not Fields
f6068cb
to
93c9152
Compare
@andrerom changed the |
93c9152
to
52e0baf
Compare
@dpobel I made all the changes suggested that are specific to Text Line, I took note of the rest and will make a dedicated PR with those since they are related to FieldType Behat in general. |
Scenario: A Content item of an Content Type that has a Text Line Field Definition must have a Text Line Field | ||
Given a Content Type with an "text line" Field exists | ||
When I create a content of this type | ||
Then I should see a "text line" field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe specify "input field" (form domain).
PlatformUI Textline BDD tests. Feature file and behat suite added.
Six test were marker with a
broken
tag, five of them depends on another Context(ContentType Context) that will be added later, since we are still improving the general organization of the Behat code.The other test marked as
broken
still need further work however I don't think we should block this PR because of it.Also added to the
runbehat.sh
script the exclusion of not working tests.depends on: ezsystems/BehatBundle#53