This repository was archived by the owner on May 3, 2022. It is now read-only.
Implement EZP-21702: Added a twig function to generation te YUI module config #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e config Set a name on the bundle so that the asset path is easy to compute.
| $this->returnValue( | ||
| function ( $path ) | ||
| { | ||
| return self::PREFIX.$path; |
There was a problem hiding this comment.
nitpick: return self::PREFIX . $path;
|
Except the nitpicks in the inline comments +1 |
|
Not an expert on the matter, but it looks good: +1 |
|
+1 as well! |
3 tasks
dpobel
added a commit
that referenced
this pull request
Nov 25, 2013
…wig_function Implement EZP-21702: Added a twig function to generate the YUI module config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-21702
Tasks: