Do not serialize empty bytes with std::memcpy, to prevent memcpy from…

…/to nullptr (even though size==0)
eyalz800 · May 5, 2023 · d01dc49 · d01dc49
1 parent 660ae01
commit d01dc49
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/zpp_bits.h b/zpp_bits.h
@@ -2043,6 +2043,10 @@ class basic_out
                     std::remove_cvref_t<decltype(*item.data())>>);
 
             auto item_size_in_bytes = item.size_in_bytes();
+            if (!item_size_in_bytes) [[unlikely]] {
+                return {};
+            }
+
             if constexpr (resizable) {
                 if (auto result = enlarge_for(item_size_in_bytes);
                     failure(result)) [[unlikely]] {
@@ -2596,6 +2600,10 @@ class in
 
             auto size = m_data.size();
             auto item_size_in_bytes = item.size_in_bytes();
+            if (!item_size_in_bytes) [[unlikely]] {
+                return {};
+            }
+
             if (item_size_in_bytes > size - m_position) [[unlikely]] {
                 return std::errc::result_out_of_range;
             }