Skip to content

Conversation

Pascal-So
Copy link
Contributor

some of these look like they might just be outdated code examples?

other things like logInfo <$> loadString res don't really make sense either way, since fmapping there would end up with a nested IO, so I replaced that with a bind.

let me know if I'm missing something or misunderstanding the examples in some way, but to me it looks like this should work better now.

@Pascal-So Pascal-So requested a review from zshipko as a code owner March 22, 2025 00:25
Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Definitely looks like some combination of wrong/outdated code

@zshipko zshipko merged commit 1c30925 into extism:main Mar 22, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants