ci: separates the upload of content to Crowdin from the download of content #1864
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bjohansebas
force-pushed
the
crowdin-pull
branch
3 times, most recently
from
6cff912 to
c6fb87e
Compare
carlosstenzel
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the upload of content to Crowdin from the download of content. It’s no longer necessary to open a PR every time we update our content—there will simply be a PR opened every Monday, like the other workflow we have.
With this change, the workflow will no longer fail when pushing (see https://github.com/expressjs/expressjs.com/actions/runs/14287448107/job/40044274294), and any errors during the download process will be easier to debug.