fix: dark/light mode theme regression #1862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <img src="/images/brand/logotype-light.svg" alt="Express.js logo" width="90" height="30"/> | ||
| </a> | ||
| <a href="/" class="hidden-light" title="Go to homepage" aria-label="Go to homepage"> | ||
| <a href="/" class="hidden-light-flex" title="Go to homepage" aria-label="Go to homepage"> |
There was a problem hiding this comment.
we should use one svg icon and change color as theme changes
There was a problem hiding this comment.
Agreed, although I don't remember why I didn't do it that way from the start. There must have been a reason, but I think we can try it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor dark/light mode theme regression introduced in #1839.
The
displaytype was switched fromblocktoflex, but the CSS wasn't updated for other uses across the site. For example, the social icons on the website footer became uncentered because some icons don't receive the dark/light mode classes. As another example, the logos on the community page lost a little bit of height asflex.The simplest solution is to give the logo introduced in #1839 it's own dark/light mode class setting
display: flexclass and let the rest of the site usedisplay: block.