build: use stylelint #1836
build: use stylelint #1836
Conversation
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bjohansebas
force-pushed
the
stylelint
branch
2 times, most recently
from
3caad8c to
3542b46
Compare
| 'no-descending-specificity': null, | ||
| // Disables the Level-4 Media Queries; Since they're more exotic and less known | ||
| 'media-feature-range-notation': 'prefix', | ||
| }, |
There was a problem hiding this comment.
consider adding following plugins
https://www.npmjs.com/package/stylelint-high-performance-animation
https://www.npmjs.com/package/stylelint-declaration-block-no-ignored-properties
Also plugin "plugin/use-defensive-css": [true, { "severity": "warning" , "accidental-hover": true, "background-repeat": true }] is useful in our code.
There was a problem hiding this comment.
Cool, that will help us maintain better CSS in this repository
There was a problem hiding this comment.
looks good to me, can we also implement a commit lint along with style lint to maintain a consistent commit message format.
There was a problem hiding this comment.
The commit lint not yet, there's no consensus on that since there are limitations in the configuration (see expressjs/discussions#293 (comment), which mentions part of that, and I'm sure there are more issues and PRs that have tried to implement it).
Step by step.
|
Next week, I will look into integrating the suggestions and merging this. |
I would like to propose using Stylelint to have a linter for CSS. This would be part of #1596.
What do you think, @expressjs/docs-wg, @ShubhamOulkar, @ipreencekmr?