docs: replace dummy with placeholder in example comments#7064
Open
stuckvgn wants to merge 2 commits intoexpressjs:masterfrom
Open
docs: replace dummy with placeholder in example comments#7064stuckvgn wants to merge 2 commits intoexpressjs:masterfrom
stuckvgn wants to merge 2 commits intoexpressjs:masterfrom
Conversation
Use more inclusive language in code comments across example files. The term 'dummy' can be replaced with the clearer, more neutral term 'placeholder' without any change in meaning. Files changed: - examples/ejs/index.js - examples/route-middleware/index.js - examples/auth/index.js
UlisesGascon
approved these changes
Feb 25, 2026
Member
|
the CI issue is not related to this (503 code error in the coverage upload service), I can retry it again in few hours (ref): |
Author
|
Thanks for the context, @UlisesGascon — just tried pushing a re-trigger commit and hit the same coveralls.io 503. Will leave it with you to retry once the service recovers. |
IamLizu
approved these changes
Feb 28, 2026
Author
|
@UlisesGascon Quick nudge — any chance the coverage job can be re-run or bypassed for merge? All tests pass across the full Node matrix, it's just the coveralls 503 holding things up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
Context
The Inclusive Naming Initiative lists dummy as a Tier 3 term to replace when possible. Placeholder is a more precise and neutral alternative that better describes the purpose of the test data in these examples.
Test plan