fix: make view engine extension matching case-insensitive#7051
Open
erdinccurebal wants to merge 1 commit intoexpressjs:masterfrom
Open
fix: make view engine extension matching case-insensitive#7051erdinccurebal wants to merge 1 commit intoexpressjs:masterfrom
erdinccurebal wants to merge 1 commit intoexpressjs:masterfrom
Conversation
When registering a view engine with a capitalized extension
(e.g. app.engine('Eta', fn)), Express stored it as '.Eta' but
file lookups returned '.eta' from path.extname(), causing a
mismatch. This normalizes extensions to lowercase in both
app.engine() and the View constructor so that engine registration
and file extension matching are case-insensitive.
Fixes expressjs#4594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.engine('Eta', fn)stored the engine under.Eta, butpath.extname('search.eta')returns.eta, causing a lookup miss and triggering an unnecessaryrequire()fallback.app.engine()and theViewconstructor so that engine registration and file extension matching are case-insensitive.Before
After
Changes
lib/application.js: normalize extension to lowercase inapp.engine()lib/view.js: normalizethis.extto lowercase inViewconstructor (both from filename and fromdefaultEngine)test/app.engine.js: 2 new tests for uppercase and mixed-case engine extensionsTest plan
view enginesettingFixes #4594