Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove .editorconfig file #6430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

Using this file was proposed in #3221 and added in efd7032, which made sense at the time because Standard was not yet integrated into the repository and organization. Now that we have Standard (which will likely change soon, see expressjs/discussions#327).

This is just another configuration file and, in my opinion, it doesn't make sense to relate it to the discussion of the new linter that will be chosen, since they serve different purposes, in my opinion.

In any case, if you don't have an extension in VSCode or your editor that supports this file, it won't work.

related: expressjs/body-parser#601

@bjohansebas bjohansebas requested review from Phillip9587 and a team April 1, 2025 14:37
Copy link
Contributor

@Phillip9587 Phillip9587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against removing it. Having this file ensures consistent practices for things like indentation, line endings, and spacing across Editors and IDEs. It can also help reduce unnecessary merge conflicts and make collaboration smoother overall. It’s a small addition that can make a big difference.

Let's discuss it in expressjs/discussions#327

@sheplu
Copy link
Member

sheplu commented Apr 1, 2025

In any case, if you don't have an extension in VSCode or your editor that supports this file, it won't work.

I may be wrong but editorconfig is understood by default by all major IDE, vscode does not need a plugin for that and I am fairly certain that this is the same for other IDEs

On a personal view, I still enforce using that to have the right per default config on for all IDEs - so I would mostly be "against removing it"

@bjohansebas
Copy link
Member Author

vscode does not need a plugin for that and I am fairly certain that this is the same for other IDEs

In these editors, a plugin needs to be installed https://editorconfig.org/#download

@Phillip9587
Copy link
Contributor

Yes, some editors do require a plugin. But take a look at the list of editors that support it natively: https://editorconfig.org/#pre-installed

It makes a lot of sense to keep that file - and maybe even add it to all our other repos.

Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep .editorconfig in all repos (and add them if they are missing)

@sheplu
Copy link
Member

sheplu commented Apr 2, 2025

I would agree to have then in all repositories, and in sync with the expected linting configuration. We should also define the content to harmonize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants