Fix repack AAB output path#3892
Conversation
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3892 +/- ##
==========================================
+ Coverage 59.01% 59.02% +0.01%
==========================================
Files 935 935
Lines 40933 40939 +6
Branches 8624 8625 +1
==========================================
+ Hits 24153 24159 +6
Misses 16684 16684
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention |
| expect(repackStep.outputById['output_path'].value).toBe('/path/to/output_app'); | ||
| }); | ||
|
|
||
| it('should rename explicit aab output path to apk', async () => { |
There was a problem hiding this comment.
isn't this weird? like what's the purpose of output_path input if it can be different in the end haha
maybe we can drop the input altogether?
There was a problem hiding this comment.
that's kind of intentional to support aab. repack wouldn't be ideal tool to support production aab build, but it's fine to repack from aab source build.
open to idea if there's a better way to support aab. (or even fine that just not to support aab)
2 participants
Why
Repacked Android builds should produce an APK output path, even when the source app path or requested output path ends in
.aab.How
Moved output path creation into a helper and rewrite
.aabpaths to.apk.Test Plan
yarn run -T oxfmt packages/build-tools/src/steps/functions/repack.ts packages/build-tools/src/steps/functions/__tests__/repack.test.tsyarn --cwd packages/build-tools jest-unit repack.test.ts --watchman=false