Skip to content

[eas-cli] Auto-create branch when channel has no branches mapped#3891

Merged
gwdp merged 3 commits into
mainfrom
gwdp/eas-update-empty-channel-autolink
Jun 24, 2026
Merged

[eas-cli] Auto-create branch when channel has no branches mapped#3891
gwdp merged 3 commits into
mainfrom
gwdp/eas-update-empty-channel-autolink

Conversation

@gwdp

@gwdp gwdp commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

eas update --channel <name> was failing with Channel has no branches associated with it when the channel existed but had no branch mapped.

This trips up fresh projects: eas build auto-creates the channel without a branch, so by the time you run eas update the channel already exists. The CLI only ever auto-created a branch when the channel was missing (ChannelNotFoundError), so the existing-but-empty channel fell through to the error instead.

Now the empty-channel case does the same thing as the missing-channel case: create a branch with the channel's name and map it.

Test plan

  • Added a unit test for the empty-channel case
  • Ran eas update --channel <empty channel> against a real project: the old CLI fails with the error above, this build creates the branch and publishes the update

@gwdp gwdp requested a review from quinlanj June 23, 2026 18:13
@gwdp gwdp marked this pull request as ready for review June 23, 2026 18:13
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/update/** @wschurman, @quinlanj

Generated by CodeMention

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.03%. Comparing base (4071f48) to head (0953405).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3891      +/-   ##
==========================================
+ Coverage   59.01%   59.03%   +0.02%     
==========================================
  Files         935      935              
  Lines       40933    40931       -2     
  Branches     8624     8622       -2     
==========================================
+ Hits        24153    24158       +5     
+ Misses      16684    16677       -7     
  Partials       96       96              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@gwdp gwdp merged commit 49101c0 into main Jun 24, 2026
10 checks passed
@gwdp gwdp deleted the gwdp/eas-update-empty-channel-autolink branch June 24, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants