Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges for 48in24 #7207

Merged
merged 12 commits into from
Jan 22, 2025
Merged

Badges for 48in24 #7207

merged 12 commits into from
Jan 22, 2025

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Dec 18, 2024

Based on the discussion in the forum: http://forum.exercism.org/t/badges-for-48in24/13869

  • "Participant in 48in24", common, earned at least one medal
  • "Larisa Latynina", rare, earned 48 medals of any colour
  • "Paavo Nurmi", ultimate, earned 48 medals with no bronze
  • "Usain Bolt", legendary, earned 48 gold medals

@glennj glennj requested a review from iHiD as a code owner December 18, 2024 23:26
@glennj glennj marked this pull request as draft December 18, 2024 23:35
@glennj glennj marked this pull request as ready for review December 19, 2024 14:06
@glennj
Copy link
Contributor Author

glennj commented Dec 19, 2024

Thank you @iHiD

Badge icons needed:

  • 48in24 participant, icon name 48_in_24
  • Larisa Latynina, name larisa-latynina
  • Paavo Nurmi, name paavo-nurmi
  • Usain Bolt, name usain-bolt

class ParticipantIn48In24Badge < Badge
seed "#48in24 Participant",
:common,
'48_in_24',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'48_in_24',
'48in24-participant',

@iHiD iHiD force-pushed the badges-for-48in24 branch from 5cc2e97 to 2ea0fd8 Compare January 22, 2025 21:54
@iHiD iHiD merged commit c20211d into exercism:main Jan 22, 2025
35 of 36 checks passed
@glennj
Copy link
Contributor Author

glennj commented Jan 22, 2025

Woot! Thanks for pushing this through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants