tests: cargo clean before checking stubs compile
#1445
Conversation
1.59.0-beta.6 (0426998f5 2022-02-02) runs into an internal compiler error unless we do this. (This has been reported to rustc in rust-lang/rust#93131) It may be a good idea to keep this `clean` in the long term anyway, so as to ensure that nothing from the "Check exercises" step unduly affects the "Ensure stubs compile" step.
(need to make any arbitrary change so that this exercise is tested in PR)
| status=1 | ||
| continue | ||
| fi | ||
| cargo clean --manifest-path "$ex/Cargo.toml" --package "$name" |
There was a problem hiding this comment.
given it only cleans the exercise package and not dependencies, I would understand objections to calling this "clean_all", in which case I would have to think of a better name. cargo_clean_exercises?
|
On the one hand this should fix the current CI issues. On the other hand, it definitely slows things down, and fast CI is important for everyone. I believe the linked issue claims that the underlying incremental compilation issue is fixed in the Rust 1.59 release, coming out in (at the time of writing) 17 days. I am reluctant to permanently degrade CI times for an issue that is likely to resolve in under three weeks. I am unwilling to claim that I will remember to revert this in three weeks, if merged. Conclusion: I am entirely uncertain as to whether this is a good idea. I reply to acknowledge that I need to think about this, and will attempt to do so in the near future. |
|
Better to quantify the slowdown. Opening a demonstrative PR where all exercises are compiled. Under ideal circumstances, the slowdown is exactly as much as would have otherwise been necessary. Because the src/lib.rs has changed from the previous compilation, it should have been necessary to recompile that in any case. In cleaning only the exercise package and crucially not any others, dependencies are not recompiled, and the hope was that there was no need to recompile those. |
|
given my seeing no appreciable difference between #1446 and a successful build on |
1.59.0-beta.6 (0426998f5 2022-02-02) runs into an internal compiler
error unless we do this.
(This has been reported to rustc in
rust-lang/rust#93131)
It may be a good idea to keep this
cleanin the long term anyway, soas to ensure that nothing from the "Check exercises" step unduly affects
the "Ensure stubs compile" step.