Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/analyzer/exercises/hamming/HammingWalker.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import com.github.javaparser.ast.expr.CharLiteralExpr;
import com.github.javaparser.ast.expr.LambdaExpr;
import com.github.javaparser.ast.expr.MethodCallExpr;
import com.github.javaparser.ast.expr.MethodReferenceExpr;
import com.github.javaparser.ast.nodeTypes.NodeWithRange;
import com.github.javaparser.ast.stmt.*;

Expand Down Expand Up @@ -75,9 +76,12 @@ private boolean isMethodCall(Statement statement) {
}

private Stream<String> getMethodCallNames(Statement statement) {
return statement.findAll(MethodCallExpr.class).stream()
.map(MethodCallExpr::getNameAsString)
.distinct();
Stream<String> methodCalled = statement.findAll(MethodCallExpr.class).stream()
.map(MethodCallExpr::getNameAsString);
Stream<String> methodRefs = statement.findAll(MethodReferenceExpr.class).stream()
.map(MethodReferenceExpr::getIdentifier);

return Stream.concat(methodCalled, methodRefs).distinct();
}

private Optional<MethodDeclaration> findGetHammingDistanceMethod() {
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/analyzer/AnalyzerIntegrationTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ void global(String scenario) throws IOException {
"OptimalWithCalculationInGetHammingDistance",
"OptimalWithValidationMethod",
"UsesCharacterLiterals",
"UsesHelperMethodInLambda",
"UsesHelperMethodInMethodRef",
"UsesStreamReduce",
})
void hamming(String scenario) throws IOException {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"comments": []
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"comments": [
{
"comment": "java.hamming.calculate_distance_in_constructor",
"params": {},
"type": "actionable"
},
{
"comment": "java.general.feedback_request",
"params": {},
"type": "informative"
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import java.util.stream.IntStream;

public class Hamming {
private final int distance;

public Hamming(String leftStrand, String rightStrand) {
if (leftStrand.length() != rightStrand.length()) {
throw new IllegalArgumentException("strands must be of equal length");
}

this.distance = (int) IntStream.range(0, leftStrand.length())
.filter(i -> leftStrand.charAt(i) != rightStrand.charAt(i))
.count();
}

public int getHammingDistance() {
return distance;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import java.util.Objects;
import java.util.stream.IntStream;

public class Hamming {
private final int length;
private final String leftStrand;
private final String rightStrand;

public Hamming(String leftStrand, String rightStrand) {
this.leftStrand = Objects.requireNonNull(leftStrand);
this.rightStrand = Objects.requireNonNull(rightStrand);

if (leftStrand.length() != rightStrand.length()) {
throw new IllegalArgumentException("strands must be of equal length");
}

this.length = leftStrand.length();
}

public int getHammingDistance() {
return IntStream.range(0, length)
.map(this::doesLetterMatch)
.sum();
}

private int doesLetterMatch(int i) {
return leftStrand.charAt(i) == rightStrand.charAt(i) ? 0 : 1;
}
}
Loading