Incorrect analyzer feedback: finalSalary should not be forced to use a ternary when Math.min is clearer #298

Activity

1. kahgoh commented on Nov 30, 2025

   

   kahgoh

   on Nov 30, 2025

   Member

   More actions

   I think the feedback is fine.

   However, this feedback appears to be incorrect.

   What does your solution look like? The feedback mentions finalSalary in the comment:

   “As the goal of this exercise is to learn about ternary operators consider using them in finalSalary to solve this exercise.”

   If you've just used Math.min, that is not the ternary operator.

   I agree that it is kinda artificial and duplicates a bit of library functionality, but I think that is fine for a bit of practice.
2. nilvon9wo commented on Dec 1, 2025

   

   nilvon9wo

   on Dec 1, 2025

   Author

   More actions

   @kahgoh ,
   I understand why I'm getting that feedback, but when I'm already demonstrating I can use the ternary operator, I don't think I should be receiving feedback which might discourge me from solving the problem in a better way. :-)

   This is my solution:

   public class SalaryCalculator {
   	private static final double BASE_SALARY = 1000.0;
   	private static final double MAX_SALARY = 2000.0;
   
   	private static final int BONUS_THRESHOLD = 20;
   	private static final int BONUS_LOW = 10;
   	private static final int BONUS_HIGH = 13;
   
   	private static final int SKIP_DAY_THRESHOLD = 5;
   	private static final double SALARY_FULL = 1.0;
   	private static final double SALARY_REDUCED = 0.85;
   
   	public double salaryMultiplier(int daysSkipped) {
   		return daysSkipped >= SKIP_DAY_THRESHOLD
   				       ? SALARY_REDUCED
   				       : SALARY_FULL;
   	}
   
   	public int bonusMultiplier(int productsSold) {
   		return productsSold >= BONUS_THRESHOLD
   				       ? BONUS_HIGH
   				       : BONUS_LOW;
   	}
   
   	public int bonusForProductsSold(int productsSold) {
   		return productsSold * bonusMultiplier(productsSold);
   	}
   
   	public double finalSalary(int daysSkipped, int productsSold) {
   		double salary = BASE_SALARY * salaryMultiplier(daysSkipped)
   				                + bonusForProductsSold(productsSold);
   
   		return Math.min(salary, MAX_SALARY);
   	}
   }