Skip to content

Update filtering helper functions definition to be more direct - #1651

Merged
jiegillet merged 2 commits into
exercism:mainfrom
sabit990928:wine-cellar-helper-docs-comment
Sep 25, 2026
Merged

jiegillet merged 2 commits into
exercism:mainfrom
sabit990928:wine-cellar-helper-docs-comment

Conversation

@sabit990928

Copy link
Copy Markdown
Contributor

What and Why

I changed the phrasing in the wine-cellar exercise for helper functions to clarify the requirements. Because while solving the problem it seemed natural to extend filtering with additional match on nil case. Which seems like not intentional as my mentor mentioned.

Maybe my wording is not best, but I think this part can be improved, so any feedback welcomed.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Concept exercise changed

    • 🌲 Do prerequisites and practices in config.json need to be updated?
    • 📖 Does the concept introduction provide all necessary information to solve this exercise?

Automated comment created by PR Commenter 🤖.

@IsaacG

IsaacG commented Sep 24, 2026

Copy link
Copy Markdown
Member

+cc @exercism/elixir

@jiegillet jiegillet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, "should not" is indeed clearer than "do not need". I'm not sure the second sentence is needed.

Comment thread exercises/concept/wine-cellar/lib/wine_cellar.ex Outdated
@jiegillet jiegillet self-assigned this Sep 25, 2026
Co-authored-by: Jie <jie.gillet@gmail.com>

@jiegillet jiegillet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@jiegillet jiegillet added x:size/small Small amount of work x:size/tiny Tiny amount of work and removed x:size/small Small amount of work labels Sep 25, 2026
@jiegillet
jiegillet merged commit edbd8e3 into exercism:main Sep 25, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/tiny Tiny amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants