Skip to content

two-fer: add generator and regenerate tests #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Jan 11, 2025

Should be merged after #728 is merged

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ErikSchierboom ErikSchierboom force-pushed the two-fer-template branch 2 times, most recently from d08d9a4 to 83a4034 Compare January 11, 2025 14:11
Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an extra line at the end of the template and a generators/.problem-specifications directory

@ErikSchierboom
Copy link
Member Author

There's also an extra line at the end of the template

That's actually intentional. See https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file for the reasoning. TL;DR: it helps with merges and diffs

[no important files changed]
@ErikSchierboom
Copy link
Member Author

@tasxatzial Updated!

Co-authored-by: Anastasios Chatzialexiou <[email protected]>
@ErikSchierboom ErikSchierboom merged commit fe9adb9 into main Jan 13, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the two-fer-template branch January 13, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants