Skip to content

two-fer: add generator and regenerate tests#733

Merged
ErikSchierboom merged 2 commits into
mainfrom
two-fer-template
Jan 13, 2025
Merged

two-fer: add generator and regenerate tests#733
ErikSchierboom merged 2 commits into
mainfrom
two-fer-template

Conversation

@ErikSchierboom

@ErikSchierboom ErikSchierboom commented Jan 11, 2025

Copy link
Copy Markdown
Member

Should be merged after #728 is merged

@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ErikSchierboom ErikSchierboom force-pushed the two-fer-template branch 2 times, most recently from d08d9a4 to 83a4034 Compare January 11, 2025 14:11

@tasxatzial tasxatzial left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also an extra line at the end of the template and a generators/.problem-specifications directory

Comment thread exercises/practice/two-fer/.meta/generator.tpl Outdated
@ErikSchierboom

Copy link
Copy Markdown
Member Author

There's also an extra line at the end of the template

That's actually intentional. See https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file for the reasoning. TL;DR: it helps with merges and diffs

[no important files changed]
@ErikSchierboom

Copy link
Copy Markdown
Member Author

@tasxatzial Updated!

Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
@ErikSchierboom ErikSchierboom merged commit fe9adb9 into main Jan 13, 2025
@ErikSchierboom ErikSchierboom deleted the two-fer-template branch January 13, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants