Skip to content

isogram: add generator template #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

isogram: add generator template #732

merged 1 commit into from
Jan 13, 2025

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Jan 11, 2025

Should be merged after #728 is merged

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be going over the exercises first.

@tasxatzial
Copy link
Member

I'm seeing the issue with the line trimming on this one. How difficult would be to do post-processing? (it looks a bit clunky as a solution). Personally I'm ok with the extra spaces.

@ErikSchierboom
Copy link
Member Author

ErikSchierboom commented Jan 12, 2025

How difficult would be to do post-processing?

Not necessary, I could tweak the template. I've updated the template and re-ran the generator and now nothing changed!

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErikSchierboom ErikSchierboom merged commit 4854d1d into main Jan 13, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the isogram-template branch January 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants