Skip to content

isogram: add generator template#732

Merged
ErikSchierboom merged 1 commit into
mainfrom
isogram-template
Jan 13, 2025
Merged

isogram: add generator template#732
ErikSchierboom merged 1 commit into
mainfrom
isogram-template

Conversation

@ErikSchierboom

@ErikSchierboom ErikSchierboom commented Jan 11, 2025

Copy link
Copy Markdown
Member

Should be merged after #728 is merged

@tasxatzial tasxatzial left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be going over the exercises first.

Comment thread exercises/practice/isogram/.meta/generator.tpl Outdated
Comment thread exercises/practice/isogram/.meta/generator.tpl Outdated
Comment thread exercises/practice/isogram/.meta/generator.tpl Outdated
Comment thread exercises/practice/isogram/.meta/generator.tpl Outdated
@tasxatzial

Copy link
Copy Markdown
Member

I'm seeing the issue with the line trimming on this one. How difficult would be to do post-processing? (it looks a bit clunky as a solution). Personally I'm ok with the extra spaces.

@ErikSchierboom

ErikSchierboom commented Jan 12, 2025

Copy link
Copy Markdown
Member Author

How difficult would be to do post-processing?

Not necessary, I could tweak the template. I've updated the template and re-ran the generator and now nothing changed!

@tasxatzial tasxatzial left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErikSchierboom ErikSchierboom merged commit 4854d1d into main Jan 13, 2025
@ErikSchierboom ErikSchierboom deleted the isogram-template branch January 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants