Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching-brackets: Explicitly check with true? in tests #700

Merged
merged 4 commits into from
Jan 11, 2025
Merged

matching-brackets: Explicitly check with true? in tests #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa8d403
update starter file
tasxatzial Nov 1, 2024
4e47176
explicitly check for `true` in tests
tasxatzial Nov 1, 2024
9fa5e5d
update config
tasxatzial Nov 8, 2024
c9197ff
rename test functions, make test descriptions identical to the ones f…
tasxatzial Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exercises/practice/matching-brackets/.meta/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"AndreaCrotti",
"haus",
"sjwarner-bp",
"yurrriq"
"yurrriq",
"tasxatzial"
],
"files": {
"solution": [
Expand Down
7 changes: 4 additions & 3 deletions exercises/practice/matching-brackets/src/matching_brackets.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
(ns matching-brackets)

(defn valid? [] ;; <- arglist goes here
;; your code goes here
)
(defn valid?
[s]
;; function body
)
94 changes: 47 additions & 47 deletions exercises/practice/matching-brackets/test/matching_brackets_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,82 +2,82 @@
(:require [clojure.test :refer [deftest testing is]]
matching-brackets))

(deftest paired-square-brackets
(deftest valid?_test_1
(testing "paired square brackets"
(is (matching-brackets/valid? "[]"))))
(is (true? (matching-brackets/valid? "[]")))))

(deftest empty-string
(testing "Empty string"
(is (matching-brackets/valid? ""))))
(deftest valid?_test_2
(testing "empty string"
(is (true? (matching-brackets/valid? "")))))

(deftest unpaired-brackets
(testing "Unpaired brackets"
(deftest valid?_test_3
(testing "unpaired brackets"
(is (false? (matching-brackets/valid? "[[")))))

(deftest wrong-ordered-brackets
(testing "Wrong ordered brackets"
(deftest valid?_test_4
(testing "wrong ordered brackets"
(is (false? (matching-brackets/valid? "}{")))))

(deftest wrong-closing-bracket
(testing "Wrong closing bracket"
(deftest valid?_test_5
(testing "wrong closing bracket"
(is (false? (matching-brackets/valid? "{]")))))

(deftest paired-with-whitespace
(testing "Paired with whitespace"
(is (matching-brackets/valid? "{ }"))))
(deftest valid?_test_6
(testing "paired with whitespace"
(is (true? (matching-brackets/valid? "{ }")))))

(deftest partially-paired-brackets
(testing "Partially paired brackets"
(deftest valid?_test_7
(testing "partially paired brackets"
(is (false? (matching-brackets/valid? "{[])")))))

(deftest simple-nested-brackets
(testing "Simple nested brackets"
(is (matching-brackets/valid? "{[]}"))))
(deftest valid?_test_8
(testing "simple nested brackets"
(is (true? (matching-brackets/valid? "{[]}")))))

(deftest several-paired-brackets
(testing "Several paired brackets"
(is (matching-brackets/valid? "{}[]"))))
(deftest valid?_test_9
(testing "several paired brackets"
(is (true? (matching-brackets/valid? "{}[]")))))

(deftest paired-and-nested-brackets
(testing "Paired and nested brackets"
(is (matching-brackets/valid? "([{}({}[])])"))))
(deftest valid?_test_10
(testing "paired and nested brackets"
(is (true? (matching-brackets/valid? "([{}({}[])])")))))

(deftest unopened-closing-brackets
(testing "Unopened closing brackets"
(deftest valid?_test_11
(testing "unopened closing brackets"
(is (false? (matching-brackets/valid? "{[)][]}")))))

(deftest unpaired-and-nested-brackets
(testing "Unpaired and nested brackets"
(deftest valid?_test_12
(testing "unpaired and nested brackets"
(is (false? (matching-brackets/valid? "([{])")))))

(deftest paired-and-wrong-nested-brackets
(testing "Paired and wrong nested brackets"
(deftest valid?_test_13
(testing "paired and wrong nested brackets"
(is (false? (matching-brackets/valid? "[({]})")))))

(deftest paired-and-wrong-nested-brackets-but-innermost-are-correct
(testing "Paired and wrong nested brackets but innermost are correct"
(deftest valid?_test_14
(testing "paired and wrong nested brackets but innermost are correct"
(is (false? (matching-brackets/valid? "[({}])")))))

(deftest paired-and-incomplete-brackets
(testing "Paired and incomplete brackets"
(deftest valid?_test_15
(testing "paired and incomplete brackets"
(is (false? (matching-brackets/valid? "{}[")))))

(deftest too-many-closing-brackets
(testing "Too many closing brackets"
(deftest valid?_test_16
(testing "too many closing brackets"
(is (false? (matching-brackets/valid? "[]]")))))

(deftest early-unexpected-brackets
(testing "Early unexpected brackets"
(deftest valid?_test_17
(testing "early unexpected brackets"
(is (false? (matching-brackets/valid? ")()")))))

(deftest early-mismatched-brackets
(testing "Early mismatched brackets"
(deftest valid?_test_18
(testing "early mismatched brackets"
(is (false? (matching-brackets/valid? "{)()")))))

(deftest math-expression
(testing "Math expression"
(is (matching-brackets/valid? "(((185 + 223.85) * 15) - 543)/2"))))
(deftest valid?_test_19
(testing "math expression"
(is (true? (matching-brackets/valid? "(((185 + 223.85) * 15) - 543)/2")))))

(deftest complex-latex-expression
(testing "Complex latex expression"
(is (matching-brackets/valid? "\\\\left(\\\\begin{array}{cc} \\\\frac{1}{3} & x\\\\\\\\ \\\\mathrm{e}^{x} &... x^2 \\\\end{array}\\\\right)"))))
(deftest valid?_test_20
(testing "complex latex expression"
(is (true? (matching-brackets/valid? "\\\\left(\\\\begin{array}{cc} \\\\frac{1}{3} & x\\\\\\\\ \\\\mathrm{e}^{x} &... x^2 \\\\end{array}\\\\right)")))))