SED-4848 Make time-series aggregations configurable on both axes - #136
SED-4848 Make time-series aggregations configurable on both axes#136jeromecomte wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces configurable group-by (series) and time-window aggregations to the time-series aggregation pipeline, adding a new Aggregation enum (AVG, SUM, COUNT) and updating queries, builders, and bucket models to support these independent aggregation axes. The review feedback highlights several improvement opportunities: making a defensive copy of attributes in BucketBuilder to prevent potential runtime exceptions from immutable maps, optimizing map lookups in TimeSeriesAggregationPipeline by moving a redundant lookup outside an inner loop, and avoiding unnecessary boxing/unboxing by changing a parameter in getBucketEnd from Long to long.
david-stephan
left a comment
david-stephan
left a comment
There was a problem hiding this comment.
Approving, because therea re no critical changes required, but added a few comments.
david-stephan
left a comment
david-stephan
left a comment
There was a problem hiding this comment.
re-approved after latest changes
2 participants
No description provided.