Refactor the API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et by sharing the `storage` instance, simplifies the API too
…ximity range in order to mimick upstream API
…oes, and update tests accordingly
obitech
reviewed
Mar 7, 2024
|
Thanks for reviewing 😊 |
FlorianLoch
deleted the
rework-api-to-allow-concurrent-updating-and-querying
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing around with the first draft some shortcomings became obvious.
So I rewrote the API to allow for concurrent access to the dataset by sharing the
storageinstance and therefore the already implemented set of locks.IMHO this also simplifies the API but having to declare the common options just once.