v1.0.0 #3
Merged
v1.0.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle disconnections through throwing methods, cleanup subscriptions * Update tests for new methods, check leftover subscriptions on tearDown() * Pass through more CoreBluetooth errors, test for retain cycles * Sync peripheral read/write/events to the same DispatchQueue * Use alternate fulfillment method * Update readme
Closed
sindresorhus
suggested changes
Dec 6, 2023
Sources/SwiftBluetooth/CentralManager/CentralManager+async.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftBluetooth/Peripheral/Peripheral+DiscoveryInfo.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftBluetooth/Peripheral/Peripheral+DiscoveryInfo.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftBluetooth/Peripheral/Peripheral+DiscoveryInfo.swift
Outdated
Show resolved
Hide resolved
… add defaults for DiscoveryInfo
…onformances, test static characteristics
…ng delegate thread
|
@exPHAT @sindresorhus Thanks for your work on this project. It makes BLE so much easier to work with. Any chance you could merge in this PR? |
|
@mgibbs189 Merged! |
|
@exPHAT That was quick, thank you! Out of curiousity, are you available for contract work? I have a small app that could use a review / sanity check 😄 |
|
@mgibbs189 Shoot me an email with some info about your project, aaron@(github username).com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2
Close #4
Close #5
Close #6
Close #7