Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThis PR adds theme-specific logo support by introducing optional CHAIN_LOGO_URL_LIGHT and CHAIN_LOGO_URL_DARK config fields. The backend CLI/env/config, AppState and API BrandingConfig were extended to carry these values; the frontend received theme-aware logo resolution and favicon updates to prefer light/dark variants. Changes
Sequence Diagram(s)sequenceDiagram
participant Env as Environment / CLI
participant Backend as Atlas Server
participant API as /api/config GET
participant Frontend as Browser App
participant Branding as BrandingContext
Env->>Backend: start with CHAIN_LOGO_URL_LIGHT/DARK or CLI args
Backend->>Backend: Config::from_env / from_run_args -> populate Config fields
Backend->>API: build AppState with chain_logo_url_light/dark
Frontend->>API: GET /api/config
API-->>Frontend: JSON includes logo_url_light/logo_url_dark when set
Frontend->>Branding: BrandingContext receives config + theme
Branding->>Branding: resolveLogoUrl(config, theme)
Branding->>Frontend: set document.title and favicon (fallback to default if null)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pthmas
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
frontend/src/context/BrandingContext.tsx (1)
20-29: Consider deriving favicon MIME type from the URL.The
type='image/png'is hardcoded, but logos could be SVG or other formats. While browsers typically ignore this attribute for favicons, consider deriving from the URL extension for correctness:🔧 Optional: derive type from URL
function setFavicon(href: string) { let link = document.querySelector<HTMLLinkElement>("link[rel='icon']"); if (!link) { link = document.createElement('link'); link.rel = 'icon'; - link.type = 'image/png'; document.head.appendChild(link); } + // Derive type from extension, fallback to png + const ext = href.split('.').pop()?.toLowerCase(); + link.type = ext === 'svg' ? 'image/svg+xml' : 'image/png'; link.href = href; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/src/context/BrandingContext.tsx` around lines 20 - 29, The setFavicon function currently hardcodes link.type = 'image/png'; change it to derive the MIME type from the href extension: parse the href (strip query/hash), get the file extension (svg, png, ico, jpg/jpeg, webp, etc.), map it to the correct MIME (e.g., image/svg+xml, image/png, image/x-icon, image/jpeg, image/webp) and set link.type to that value (or omit/set to empty if unknown); update the code around the document.querySelector/createElement logic so link.type uses this derived MIME before appending or updating the href, and ensure it handles URLs with query strings or fragments.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/src/context/branding.test.ts`:
- Around line 1-2: The CI fails because TypeScript type-checking runs over test
files importing "bun:test" (see frontend/src/context/branding.test.ts import of
'bun:test'), so replace the build pipeline command "tsc -b && vite build" in
package.json with "bunx vite build" to skip global tsc type-checking; also add
"@types/bun" to devDependencies and update tsconfig.app.json to include "types":
["bun/types"] so editors/linters resolve bun symbols (affects imports like
'bun:test' and functions referenced such as resolveLogoUrl).
---
Nitpick comments:
In `@frontend/src/context/BrandingContext.tsx`:
- Around line 20-29: The setFavicon function currently hardcodes link.type =
'image/png'; change it to derive the MIME type from the href extension: parse
the href (strip query/hash), get the file extension (svg, png, ico, jpg/jpeg,
webp, etc.), map it to the correct MIME (e.g., image/svg+xml, image/png,
image/x-icon, image/jpeg, image/webp) and set link.type to that value (or
omit/set to empty if unknown); update the code around the
document.querySelector/createElement logic so link.type uses this derived MIME
before appending or updating the href, and ensure it handles URLs with query
strings or fragments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a4d52312-074f-4722-9206-8f8a9d852b30
📒 Files selected for processing (13)
.env.examplebackend/crates/atlas-server/src/api/handlers/config.rsbackend/crates/atlas-server/src/api/handlers/faucet.rsbackend/crates/atlas-server/src/api/handlers/status.rsbackend/crates/atlas-server/src/api/mod.rsbackend/crates/atlas-server/src/cli.rsbackend/crates/atlas-server/src/config.rsbackend/crates/atlas-server/src/main.rsbackend/crates/atlas-server/tests/integration/common.rsfrontend/src/api/config.tsfrontend/src/context/BrandingContext.tsxfrontend/src/context/branding.test.tsfrontend/src/context/branding.ts
Collaborator
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by CodeRabbit
New Features
Documentation
Tests