Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5: Move Pylint config to .pylintrc.toml, remove default config values #11

Merged
merged 2 commits into from
Sep 26, 2024
Merged

#5: Move Pylint config to .pylintrc.toml, remove default config values #11

merged 2 commits into from
Sep 26, 2024

Conversation

nifadyev
Copy link
Contributor

Related to #5

nifadyev
nifadyev commented Aug 30, 2024
View reviewed changes
{{cookiecutter.project_name}}/.pylintrc.toml Outdated
"redefined-builtin",
"import-outside-toplevel",
"no-else-return",
"unspecified-encoding",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bad practice to open file without encoding. Any example when this check should be ignored?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example when this check should be ignored?

No, I can't suppose/guess

nifadyev
nifadyev commented Aug 30, 2024
View reviewed changes
{{cookiecutter.project_name}}/.pylintrc.toml Outdated
"import-outside-toplevel",
"no-else-return",
"unspecified-encoding",
"duplicate-code",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this from ignore? It is better to explicitly mark duplicated code for ignoring

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, thank you.

nifadyev
nifadyev commented Aug 30, 2024
View reviewed changes
{{cookiecutter.project_name}}/.pylintrc.toml Outdated
"no-else-return",
"unspecified-encoding",
"duplicate-code",
"super-with-arguments",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it useful to ignore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I guess no - it would be better to get an error and take care of ignoring this rule if needed

soltanoff
soltanoff requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@soltanoff soltanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, could you describe me reasons that helped you to made a desicion to create .pylintrc.toml from pyproject.toml?

@nifadyev
Copy link
Contributor Author

Hm, could you describe me reasons that helped you to made a desicion to create .pylintrc.toml from pyproject.toml?

Sure. Initial pylint config is 100+ lines long and it makes pyproject.toml hard to read. But cleaned config is only ~50 LOC, so i guess it is OK to store it in pyproject.toml

@soltanoff
Copy link
Member

@nifadyev, rebase it, please :)

@nifadyev nifadyev force-pushed the feature/#5/move-pylint-config-to-own-file branch from 2fb5367 to 31c0631 Compare September 23, 2024 13:01
@soltanoff soltanoff merged commit 1047914 into evrone:master Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltanoff soltanoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nifadyev @soltanoff