Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Upgrade to tailwind 4 #3041

Draft
wants to merge 36 commits into
base: next
Choose a base branch
from
Draft

Feat: Upgrade to tailwind 4 #3041

wants to merge 36 commits into from

Conversation

ItsMeBrianD
Copy link
Member

Description

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@evidence-dev/sdk and @evidence-dev/universal-sql
  has a circular dependency, which should be remedied

This means that we will have to do a bit of DI, as
well as losing the detailed logs for build-parquet
(for now)
This commit only has a cursory validation that the
styles are equivilant, and that will need to be
checked again before this is put into main
@archiewood
Copy link
Member

archiewood commented Jan 27, 2025

there are some useful looking chromatic test failures here

CleanShot 2025-01-27 at 17 51 43@2x

@archiewood
Copy link
Member

archiewood commented Jan 27, 2025

I think this is currently choking on the docs deploy because we use an inline style with an explicit color in

sites/docs/pages/build-your-first-app/index.md

[@tailwindcss/vite:generate:build] Cannot apply unknown utility class: border-gray-200

CleanShot 2025-01-27 at 17 59 50@2x

We can obviously remove this in the docs, but I think this means there is a regression in the backwards compat for named colours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants