Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle neverShowQueries inside the KebabMenu component. #2950

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

ismailsunni
Copy link

Description

Basically, handle the neverShowQueries props inside the KebabMenu to match with the documentation (so no need to update the doc) and I guess, this is normally what I would do (so that it's not hiding the whole KebabMenu)

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR December 21, 2024 01:24 — with GitHub Actions Inactive
@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR December 21, 2024 01:24 — with GitHub Actions Inactive
@archiewood
Copy link
Member

This looks great, thank you

@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR January 2, 2025 03:29 — with GitHub Actions Inactive
@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR January 2, 2025 03:29 — with GitHub Actions Inactive
@archiewood archiewood requested a review from ItsMeBrianD January 2, 2025 15:27
@archiewood
Copy link
Member

@ismailsunni I think you need to run pnpm i and commit the updated pnpm-lock.yaml file to get the CI tests to run

@ismailsunni
Copy link
Author

@archiewood I alreday did, and this commit cedf20b already has the content of the updated pnpm-lock.yaml not sure what I did wrong here.

@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR January 4, 2025 00:46 — with GitHub Actions Inactive
@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR January 4, 2025 00:46 — with GitHub Actions Inactive
@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR January 12, 2025 14:31 — with GitHub Actions Inactive
@ismailsunni ismailsunni temporarily deployed to Approval required to run action on external PR January 12, 2025 14:31 — with GitHub Actions Inactive
@archiewood archiewood added the needs-ci Maintainer to review and start CI label Jan 14, 2025
@zachstence zachstence removed the needs-ci Maintainer to review and start CI label Jan 16, 2025
Copy link
Member

@archiewood archiewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing both the basic and the themes end-to-end tests to fail. The logs suggest that the button they need to see is not visible within 30 seconds

Logs (themes)
openKebabMenu failed locator.click: Test timeout of 30000ms exceeded.
Call log:
  - waiting for getByRole('button', { name: 'Menu' })

    at openKebabMenu (D:\a\evidence\evidence\e2e\test-utils.js:48:52)
    at getAppearance (D:\a\evidence\evidence\e2e\test-utils.js:84:3)
    at switchAppearance (D:\a\evidence\evidence\e2e\test-utils.js:108:17)
    at D:\a\evidence\evidence\e2e\themes\tests\tests.spec.js:40:2 {
  [Symbol(step)]: {
    stepId: 'pw:api@13',
    location: {
      file: 'D:\\a\\evidence\\evidence\\e2e\\test-utils.js',
      line: 48,
      column: 52,
      function: 'openKebabMenu'
    },
    category: 'pw:api',
    title: "locator.getByRole('button', { name: 'Menu' }).click",
    apiName: 'locator.click',
    params: { selector: 'internal:role=button[name="Menu"i]', strict: true },
    boxedStack: undefined,
    steps: [],
    complete: [Function: complete],
    endWallTime: 1737048607853,
    error: {
      message: 'Error: locator.click: Test timeout of 30000ms exceeded.\n' +
        'Call log:\n' +
        "\x1B[2m  - waiting for getByRole('button', { name: 'Menu' })\x1B[22m\n",
      stack: 'Error: locator.click: Test timeout of 30000ms exceeded.\n' +
        'Call log:\n' +
        "\x1B[2m  - waiting for getByRole('button', { name: 'Menu' })\x1B[22m\n" +
        '\n' +
        '    at openKebabMenu (D:\\a\\evidence\\evidence\\e2e\\test-utils.js:48:52)\n' +
        '    at getAppearance (D:\\a\\evidence\\evidence\\e2e\\test-utils.js:84:3)\n' +
        '    at switchAppearance (D:\\a\\evidence\\evidence\\e2e\\test-utils.js:108:17)\n' +
        '    at D:\\a\\evidence\\evidence\\e2e\\themes\\tests\\tests.spec.js:40:2',
      cause: undefined
    }
  }
}

@zachstence zachstence self-assigned this Feb 3, 2025
@zachstence zachstence deployed to Approval required to run action on external PR February 3, 2025 16:38 — with GitHub Actions Active
@zachstence zachstence temporarily deployed to Approval required to run action on external PR February 3, 2025 16:38 — with GitHub Actions Inactive
@ismailsunni
Copy link
Author

@archiewood I see, thanks for the pointer. I will try to fix the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants