-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle neverShowQueries inside the KebabMenu component. #2950
base: next
Are you sure you want to change the base?
Conversation
This looks great, thank you |
@ismailsunni I think you need to run |
@archiewood I alreday did, and this commit cedf20b already has the content of the updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing both the basic
and the themes
end-to-end tests to fail. The logs suggest that the button they need to see is not visible within 30 seconds
Logs (themes)
openKebabMenu failed locator.click: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByRole('button', { name: 'Menu' })
at openKebabMenu (D:\a\evidence\evidence\e2e\test-utils.js:48:52)
at getAppearance (D:\a\evidence\evidence\e2e\test-utils.js:84:3)
at switchAppearance (D:\a\evidence\evidence\e2e\test-utils.js:108:17)
at D:\a\evidence\evidence\e2e\themes\tests\tests.spec.js:40:2 {
[Symbol(step)]: {
stepId: 'pw:api@13',
location: {
file: 'D:\\a\\evidence\\evidence\\e2e\\test-utils.js',
line: 48,
column: 52,
function: 'openKebabMenu'
},
category: 'pw:api',
title: "locator.getByRole('button', { name: 'Menu' }).click",
apiName: 'locator.click',
params: { selector: 'internal:role=button[name="Menu"i]', strict: true },
boxedStack: undefined,
steps: [],
complete: [Function: complete],
endWallTime: 1737048607853,
error: {
message: 'Error: locator.click: Test timeout of 30000ms exceeded.\n' +
'Call log:\n' +
"\x1B[2m - waiting for getByRole('button', { name: 'Menu' })\x1B[22m\n",
stack: 'Error: locator.click: Test timeout of 30000ms exceeded.\n' +
'Call log:\n' +
"\x1B[2m - waiting for getByRole('button', { name: 'Menu' })\x1B[22m\n" +
'\n' +
' at openKebabMenu (D:\\a\\evidence\\evidence\\e2e\\test-utils.js:48:52)\n' +
' at getAppearance (D:\\a\\evidence\\evidence\\e2e\\test-utils.js:84:3)\n' +
' at switchAppearance (D:\\a\\evidence\\evidence\\e2e\\test-utils.js:108:17)\n' +
' at D:\\a\\evidence\\evidence\\e2e\\themes\\tests\\tests.spec.js:40:2',
cause: undefined
}
}
}
@archiewood I see, thanks for the pointer. I will try to fix the test |
Description
Basically, handle the neverShowQueries props inside the KebabMenu to match with the documentation (so no need to update the doc) and I guess, this is normally what I would do (so that it's not hiding the whole KebabMenu)
Checklist