fix(api): terminalize stale archived snapshot jobs - #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo fmt --all -- --checkcargo clippy -p sandboxwich-api --all-targets -- -D warningscargo test -p sandboxwich-api --test http_contract(135 passed)SANDBOXWICH_UPDATE_OPENAPI_EXPORT=1 cargo test -p sandboxwich-api --bin sandboxwich-api api_contract::tests::committed_openapi_export_is_currentRoot cause
Claim-time placement filtering correctly refuses queued jobs whose archived source has no valid placement, but legacy standalone snapshot jobs could remain queued indefinitely after the source sandbox entered teardown.
Rollback
Revert this commit; the existing claim filters and cancellation behavior remain available without the repair sweep.