-
Notifications
You must be signed in to change notification settings - Fork 54.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomix Intro Project #2675
Atomix Intro Project #2675
Conversation
1. Module name is changed. 2. Module name is updated in pom.xml.
d7e6bc6
to
95cc173
Compare
atomix/pom.xml
Outdated
<artifactId>maven-compiler-plugin</artifactId> | ||
<version>3.1</version> | ||
<configuration> | ||
<source>1.3</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abirkhan04 why so low version numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am updating version number.
public class ClientExampleTest { | ||
|
||
@Test | ||
public void ExampleTest() throws InterruptedException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the naming convention specified in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check-back the documentation what I am missing here.
client.connect(cluster) | ||
.thenRun(() -> System.out.println("Client Connected")); | ||
|
||
Thread.sleep(5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we replace this with Awaitility or any other form of testing things that happen asynchronously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did forced synchronization here so that I could make sure client is connected to the cluster and I can retrieve the map value from there in the following line. My intention here is not to illustrate the asynchronous nature of the program rather than retrieving distributed resource from cluster that was created and written by other entity.
This reverts commit cfb952f.
No description provided.