Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomix Intro Project #2675

Merged
merged 7 commits into from
Sep 30, 2017
Merged

Atomix Intro Project #2675

merged 7 commits into from
Sep 30, 2017

Conversation

abirkhan04
Copy link
Contributor

No description provided.

atomix/pom.xml Outdated
<artifactId>maven-compiler-plugin</artifactId>
<version>3.1</version>
<configuration>
<source>1.3</source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abirkhan04 why so low version numbers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am updating version number.

public class ClientExampleTest {

@Test
public void ExampleTest() throws InterruptedException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the naming convention specified in the documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check-back the documentation what I am missing here.

client.connect(cluster)
.thenRun(() -> System.out.println("Client Connected"));

Thread.sleep(5000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we replace this with Awaitility or any other form of testing things that happen asynchronously?

Copy link
Contributor Author

@abirkhan04 abirkhan04 Sep 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did forced synchronization here so that I could make sure client is connected to the cluster and I can retrieve the map value from there in the following line. My intention here is not to illustrate the asynchronous nature of the program rather than retrieving distributed resource from cluster that was created and written by other entity.

@pivovarit pivovarit closed this Sep 30, 2017
@pivovarit pivovarit reopened this Sep 30, 2017
@pivovarit pivovarit merged commit cfb952f into eugenp:master Sep 30, 2017
pivovarit added a commit that referenced this pull request Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants