actions: Set up shellcheck and apply suggested changes

.github/workflows/codestyle.yml

@@ -12,6 +12,21 @@ name: Codestyle checks
       - nodejs-frontend  # TODO: Remove me when web-frontend is merged
 
 jobs:
+  shellcheck:
+    name: Run shellcheck style checks
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/[email protected]
+
+      - uses: cachix/install-nix-action@v13
+        with:
+          nix_path: nixpkgs=channel:nixos-unstable
+
+      - name: Prefetch shell.nix
+        run: 'nix-shell --run true'
+
+      - run: nix-shell --run "make shellcheck"
+
   yamllint:
     name: Run yamllint on github actions files
     runs-on: ubuntu-latest

Makefile

@@ -1,2 +1,5 @@
+shellcheck:
+	shellcheck checkup.bash
+
 yamllint:
 	yamllint -s -f github .github/workflows/*

checkup.bash

@@ -85,15 +85,15 @@ cmd_checkup_check_file() {
     endOfHash=${hash:5:35}
 
     # Get filtered leaked hashes
-    leakedHashes=$(curl -H 'user-agent: pass-checkup-extension; github.com/etu/pass-checkup' -s "https://api.pwnedpasswords.com/range/${startOfHash}" | grep -i $endOfHash)
+    leakedHashes=$(curl -H 'user-agent: pass-checkup-extension; github.com/etu/pass-checkup' -s "https://api.pwnedpasswords.com/range/${startOfHash}" | grep -i "$endOfHash")
 
     # Define some color codes
     RED='\033[0;31m'
     GREEN='\033[0;32m'
     NC='\033[0m' # No Color
 
     # Check if password is leaked or not
-    if test $(echo -n $leakedHashes | wc -c) = 0; then
+    if test "$(echo -n "$leakedHashes" | wc -c)" = 0; then
         echo -e "${GREEN}${path}: Password is probably not leaked ✔️${NC}"
     else
         RETURNCODE=2

shell.nix

@@ -5,6 +5,9 @@ pkgs.mkShell {
     # Install GNU Make for shorthands
     pkgs.gnumake
 
+    # Install shellcheck
+    pkgs.shellcheck
+
     # Install yaml lint
     pkgs.yamllint
   ];