Added unit tests for msf_core state accessors #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CATKIN_DEPENDS roscpp sensor_msgs dynamic_reconfigure msf_timing tf | ||
| INCLUDE_DIRS include ${Eigen_INCLUDE_DIRS} | ||
| LIBRARIES msf_core similaritytransform | ||
| CFG_EXTRAS export_flags.cmake | ||
| CFG_EXTRAS export_flags.cmake FindGLog.cmake |
There was a problem hiding this comment.
really?! thanks a lot, catkin ...
There was a problem hiding this comment.
Actually not sure, lets try without
There was a problem hiding this comment.
it somewhat makes sense if you checked in your own find-script, I guess dependencies of msf_core may need it in order to find the include dirs. I was just a bit unhappy about one more thing that one needs to remember doing when using catkin ...
|
@markusachtelik Is this good to go? |
|
looks good to me - but jenkins seems to have a different opinion |
simonlynen
added a commit
that referenced
this pull request
Mar 25, 2014
…e_accessors Added unit tests for msf_core state accessors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.