-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make error naming in evm uniform #3968
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4e5ce25
to
b58590e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would cautiously think this looks good, but will leave it to Jochem for a final review!
This change does the following:
EOFError
key names are all made to be capital snakecaseSimpleError
key names are all made to be capital snakecaseEOFError
andSimpleError
(soERROR
->EVMError
and the type namedERROR
->EVMErrorType
)exceptions.ts
toerrors.ts
to be more consistent with the file naming used for the eof errors