Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error naming in evm uniform #3968

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Apr 9, 2025

This change does the following:

  • EOFError key names are all made to be capital snakecase
  • SimpleError key names are all made to be capital snakecase
  • The main error map for the evm is made to be camel case as are EOFError and SimpleError (so ERROR -> EVMError and the type named ERROR -> EVMErrorType)
  • The name of the file containing all of the main error codes for the evm is renamed from exceptions.ts to errors.ts to be more consistent with the file naming used for the eof errors

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 62.33766% with 145 lines in your changes missing coverage. Please review.

Project coverage is 79.64%. Comparing base (d6d3858) to head (b58590e).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 83.29% <ø> (ø)
blockchain 89.33% <ø> (ø)
client 68.10% <ø> (ø)
common 98.49% <ø> (ø)
devp2p 86.73% <ø> (ø)
evm 72.99% <62.33%> (+0.01%) ⬆️
genesis 99.98% <ø> (ø)
mpt 89.71% <ø> (-0.06%) ⬇️
rlp 91.43% <ø> (ø)
statemanager 69.16% <ø> (ø)
tx 90.58% <ø> (ø)
util 81.96% <ø> (ø)
vm 57.20% <ø> (ø)
wallet 88.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scorbajio scorbajio linked an issue Apr 9, 2025 that may be closed by this pull request
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would cautiously think this looks good, but will leave it to Jochem for a final review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM errors use inconsistent casing
2 participants